DM-46777: Add a lower bound on sphinxcontrib-mermaid, revert sphinx pin #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
force-pushed
the
tickets/DM-46777/revert-sphinx-pin
branch
from
bd217de
to
7e1ea54
Compare
|
I think this still counts as a bugfix even though we're changing the version of mermaidjs that gets pulled in, but I could be convinced otherwise. |
rra
approved these changes
Oct 15, 2024
fajpunk
changed the title
* Set a lower bound on sphinxcontrib-mermaid to <=1 * Revert the Sphinx pin because this fixes the compatibility issue * Ditch the `mermaid_version` pin because this fixes mgaitan/sphinxcontrib-mermaid#110
fajpunk
force-pushed
the
tickets/DM-46777/revert-sphinx-pin
branch
from
7e1ea54
to
dbf6183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mermaid_versionpin because this fixes mermaid cdn change? mgaitan/sphinxcontrib-mermaid#110as, not sure if that's a mypy bug, or if those are the real rules and it's a mypy fix)Tested: